FileVideoStream class - threading bugfixes, resource releasing #86
Merged
jrosebr1 merged 2 commits intoPyImageSearch:masterfrom Oct 29, 2018
Merged
FileVideoStream class - threading bugfixes, resource releasing #86jrosebr1 merged 2 commits intoPyImageSearch:masterfrom
jrosebr1 merged 2 commits intoPyImageSearch:masterfrom
Conversation
Contributor
Author
|
I have added another bugfix. When consumer is faster than producer which sometimes can happen due to preprocessing transform method called, reading would end after calling more() because queue is empty. However, we first need to check if stream is stopped and if not then try to wait a little bit. |
Contributor
|
Thanks @lukasbrchl! Merging in. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have made some minor improvements to the filevideostream.py.
The problem was caused by main thread not waiting for producer and exiting while producer was still grabbing the frames. So I added thread.join() to stop() method.
Similar issues are also discussed in #85 #81 #47 #35 for WebCam stream. This could be easily modified to follow the same style. They also free cv2.VideoCapture before exiting update() method.